Skip to content

Bilinear delta formulation-based OptimizationContainer test#40

Draft
luke-kiernan wants to merge 11 commits intomainfrom
ac/network_benchmark
Draft

Bilinear delta formulation-based OptimizationContainer test#40
luke-kiernan wants to merge 11 commits intomainfrom
ac/network_benchmark

Conversation

@luke-kiernan
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Collaborator Author

@luke-kiernan luke-kiernan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small things. But the bigger concern: when I run this, I get that the objective value is 0.0. I suspect it's due to the fact that you're making the power at the loads a variable, not a fixed quantity. If that isn't it, then I'd suggest taking a detailed look at the constraints and objective function for a super small case, like 2 nodes and 2 tranches.

@acostarelli acostarelli self-assigned this Mar 16, 2026
return points
end

struct NetworkProblem
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
struct NetworkProblem
struct MockNetworkProblem

)
end

# ----------------- Mock infrastructure
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this to appropriate file inside the mocks

@test PSI.get_warm_start(settings) == true
@test PSI.get_optimizer(settings) === nothing
@test PSI.get_direct_mode_optimizer(settings) == false
@test PSI.get_direct_model_optimizer(settings) == false
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@test PSI.get_direct_model_optimizer(settings) == false
@test PSI.get_direct_mode_optimizer(settings) == false

Direct mode is a reference to JuMP direct_mode not model

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. It seems that JuMP refers to both a direct_model as well as a direct mode: https://jump.dev/JuMP.jl/stable/api/JuMP/#direct_model

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants